View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000992K18X001.00 SKB SWANSW Issuepublic2020-10-26 15:462021-09-07 19:00
Reporter(ALTech) Wooshin Kang Assigned To(ALTech) Wooshin Kang Due Date2020-10-30 16:32
PriorityurgentSeveritys2-severeReproducibilityalways
Status closedResolutionfixed 
Summary0000992: [SWAN] Please implement enable/disable function of DRC, EQ of AMP (82584,83586)
DescriptionDear Jacky,

SKT manager requests some function to disable or enable EQ and DRC function of AMP.
He doesn't want to be enable EQ, DRC of AMP during NUGU call.
And he will control it himself during implementation of NUGU call. Please support these function for him.

Thanks.


TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List (ALTech) Lonnie Kim , (SW) Jerry Lin , (SW) Sam Yang

Activities

(SW) River Wong

2020-10-27 14:16

developer   ~0004755

Hi Wooshin,

Where do SKT wants to call these APIs?
For example, from Android Audio HAL? or from Android app?
Do they want to define BTF HAL API for this?

(ALTech) Wooshin Kang

2020-10-27 15:15

developer   ~0004758

Hi River,
SKT don't use BTF HAL API.
And I have no source code so i don't know exact position.
I know that he added source and header file to "/vendor/synaptics/common/audio" and change some file in this folder to implement NUGU.
If you implement functions in same folder, i will expect that he can call this functions.

thanks.

(SW) River Wong

2020-10-27 15:33

developer   ~0004759

Hi Wooshin,

There is no folder for /vendor/synaptics/common/audio.
But there is a folder vendor/synaptics/vsxxx/audio. This folder is for Android Audio HAL. I remember SKT also report fail to use pcm_open in this folder.

(ALTech) Wooshin Kang

2020-10-27 16:22

developer   ~0004761

Dear River,

Yes, you are right.
Thanks.

(SW) River Wong

2020-11-02 17:52

developer   ~0004814

Hi Wooshin,

I commit the code about to enable/disable DRC and EQ of AMPS into bitbucket.
It seems there is a code to handle it in /vendor/synaptics/vxss/audio/AudioStreamNXPIn.cpp. So, I directly change the code in it.
You change the AudioStreamNXPIn::AudioStreamNXPIn() and AudioStreamNXPIn::~AudioStreamNXPIn().
Please let SKT check if this meet their requirement.

Bitbucket commit log is as following:

commit ff55134a718a7ec49a3cdb030e2843e5b659e304
Author: river wong <river.wong@fii-foxconn.com>
Date: Mon Nov 2 17:45:32 2020 +0800

    Add enable/disable function of DRC, EQ of AMP (AD82584F,AD83586B)

(ALTech) Wooshin Kang

2020-11-03 09:16

developer   ~0004823

Dear River,

Please inform about function name in which file. I can't see source code.

Thanks

(SW) River Wong

2020-11-03 09:37

developer   ~0004825

Hi Wooshin,

You can tell SKT to check the /vendor/synaptics/vxss/audio/AudioStreamNXPIn.cpp. I add a new I2C function to control the register of AMPs.
The new I2C function is VENDOR_HAL_I2C_AudioWriteMask(). The registers control for AMPs are list in AudioStreamNXPIn::AudioStreamNXPIn() and AudioStreamNXPIn::~AudioStreamNXPIn() in /vendor/synaptics/vxss/audio/AudioStreamNXPIn.cpp.

(SW) River Wong

2020-11-11 09:24

developer   ~0004932

Resolved.

(ALTech) Wooshin Kang

2020-11-24 10:52

developer   ~0005128

It is using by pre-process for nugu.

(ALTech) Wooshin Kang

2021-08-03 16:25

developer   ~0007790

Amp b/d is changed and EQ and DR of should be disabled by default. so we don't need to turn on/off api for EQ and DRC.
But we need function to turn on/off DSP function. Please replace code for DSP on/off inside
AudioStreamNXPIn::AudioStreamNXPIn() and AudioStreamNXPIn::~AudioStreamNXPIn() in /vendor/synaptics/vxss/audio/AudioStreamNXPIn.cpp.

DSP Play Mode :
i2cset 0 -y 0x20 0 0x11 b
DSP bypass Mode :
i2cset 0 -y 0x20 0 0x22 b

Thanks.

(ALTech) Wooshin Kang

2021-08-03 16:27

developer   ~0007791

To do
1. EQ and DRC off by default.
2. Add A113x bypass mode on/off function.

Thanks.

(SW) River Wong

2021-08-04 11:08

developer   ~0007794

Last edited: 2021-08-04 11:14

 Hi Wooshin,

I implemented the i2c commands but I do not know when I can commit it to Bitbucket.
Because it also need the change of Wellang driver that disable DRC/EQ by default (This is not committed yet).
So, please confirm the following questions:
1.Could you confirm with Lonnie that the image to disable DRC/EQ of Wellang amplifier in https://172.18.223.170/vaas/view.php?id=1296 is Ok or not?
2.When can we commit the code for both Wellang driver(disable DRC/EQ by default) and this A113X DRC/EQ I2C control implementation?

(ALTech) Wooshin Kang

2021-08-04 15:13

developer   ~0007795

Hi River,

1. it also need the change of Wellang driver that disable DRC/EQ by default (This is not committed yet). -> Please do commit.
2. I can't confirm it, but nobody can't confirm it at now. but we need it.
3. Yes, you can commit it. If there is side effect, let's revert.

thanks.

(SW) River Wong

2021-08-04 18:12

developer   ~0007801

Hi Wooshin,

Ok, I committed the code to control A113X DRC/EQ.
About the Wellang Driver to disable DRC/EQ by default, Sam will help to commit it latter.

Hi Sam,

After you commit your code, please update it here.

(SW) Sam Yang

2021-08-05 09:48

developer   ~0007807

report:
Already commited, "snd-soc-wa206829b.ko" md5 checksum = 5bcefd19af887f23986d4f50a1175591

(ALTech) Wooshin Kang

2021-08-17 16:54

developer   ~0007878

HI river and sam.

SKT want to set high volume level during NUGU call.
So, we need to add it in AudioStreamNXPIn::AudioStreamNXPIn() and AudioStreamNXPIn::~AudioStreamNXPIn() in /vendor/synaptics/vxss/audio/AudioStreamNXPIn.cpp.

I use following command when i set volume level in console.

Enter nugu call
i2cset -f -y 0 0x2b 0x17 0xb2 b
i2cset -f -y 0 0x2b 0x18 0xb2 b
 
i2cset -f -y 0 0x2d 0x17 0xb2 b
i2cset -f -y 0 0x2d 0x18 0xb2 b

Exit nugu call
i2cset -f -y 0 0x2b 0x17 0x9f b
i2cset -f -y 0 0x2b 0x18 0x9f b
 
i2cset -f -y 0 0x2d 0x17 0x9f b
i2cset -f -y 0 0x2d 0x18 0x9f b

** 0x9f is default value.

Nugu's requirement.
1. Woofer disable
2. A113x bypass
3. Volume up.

Thanks.

(SW) River Wong

2021-08-17 17:27

developer   ~0007879

Hi Wooshin,

I suggest to add back Jerry's LKFS commit and then find the 0x17,0x18 register value again for NUGU call.
Because Jerry's commit for LKFS can avoid give out of spec power to Speakers and avoid damage of Speakers for long term.
Jerry's commit only make NUGU Call volume too small, but I think with bigger value of register 0x17 and 0x18 can fix it.

(SW) River Wong

2021-09-07 17:56

developer   ~0008102

Already apply new Wellang Amp driver to DRC=on, EQ=OFF and limite 8W/30W.
And also add code to control DRC/EQ and woofer mutein NUGU call.

Issue History

Date Modified Username Field Change
2020-10-26 15:46 (ALTech) Wooshin Kang New Issue
2020-10-26 15:46 (ALTech) Wooshin Kang Status new => assigned
2020-10-26 15:46 (ALTech) Wooshin Kang Assigned To => (SW) Jacky Chiang
2020-10-27 14:16 (SW) River Wong Note Added: 0004755
2020-10-27 15:15 (ALTech) Wooshin Kang Note Added: 0004758
2020-10-27 15:33 (SW) River Wong Note Added: 0004759
2020-10-27 16:22 (ALTech) Wooshin Kang Note Added: 0004761
2020-11-02 17:52 (SW) River Wong Note Added: 0004814
2020-11-02 17:55 (SW) River Wong Assigned To (SW) Jacky Chiang => (SW) River Wong
2020-11-03 09:16 (ALTech) Wooshin Kang Note Added: 0004823
2020-11-03 09:37 (SW) River Wong Note Added: 0004825
2020-11-11 09:24 (SW) River Wong Assigned To (SW) River Wong => (ALTech) Wooshin Kang
2020-11-11 09:24 (SW) River Wong Status assigned => resolved
2020-11-11 09:24 (SW) River Wong Resolution open => fixed
2020-11-11 09:24 (SW) River Wong Note Added: 0004932
2020-11-13 11:27 (SW) Jacky Chiang Project T99X171.00 SKB Eagle => K18X001.00 SKB SWAN
2020-11-24 10:52 (ALTech) Wooshin Kang Status resolved => closed
2020-11-24 10:52 (ALTech) Wooshin Kang Note Added: 0005128
2021-08-03 16:25 (ALTech) Wooshin Kang Status closed => feedback
2021-08-03 16:25 (ALTech) Wooshin Kang Resolution fixed => reopened
2021-08-03 16:25 (ALTech) Wooshin Kang Note Added: 0007790
2021-08-03 16:25 (ALTech) Wooshin Kang Assigned To (ALTech) Wooshin Kang => (SW) River Wong
2021-08-03 16:27 (ALTech) Wooshin Kang Note Added: 0007791
2021-08-03 16:27 (ALTech) Wooshin Kang Status feedback => assigned
2021-08-04 11:00 (SW) River Wong Issue Monitored: (ALTech) Lonnie Kim
2021-08-04 11:08 (SW) River Wong Note Added: 0007794
2021-08-04 11:14 (SW) River Wong Note Edited: 0007794
2021-08-04 15:13 (ALTech) Wooshin Kang Note Added: 0007795
2021-08-04 18:01 (SW) River Wong Issue Monitored: (SW) Sam Yang
2021-08-04 18:12 (SW) River Wong Note Added: 0007801
2021-08-05 09:48 (SW) Sam Yang Note Added: 0007807
2021-08-17 16:54 (ALTech) Wooshin Kang Note Added: 0007878
2021-08-17 17:27 (SW) River Wong Note Added: 0007879
2021-08-17 17:28 (SW) River Wong Issue Monitored: (SW) Jerry Lin
2021-09-07 17:56 (SW) River Wong Assigned To (SW) River Wong => (ALTech) Wooshin Kang
2021-09-07 17:56 (SW) River Wong Status assigned => resolved
2021-09-07 17:56 (SW) River Wong Resolution reopened => fixed
2021-09-07 17:56 (SW) River Wong Note Added: 0008102
2021-09-07 19:00 (ALTech) Wooshin Kang Status resolved => closed